It’s very silly and hugely inaccurate but I do love the Shanghai Knights.
I find the bit where Lin kills Jack the Ripper very funny and Aidan Gillen as Lord Nelson Rathbone makes a very wondefully sadistic villain. It is one of my favourite Jackie Chan movies.